Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11135 )
Change subject: [Java] Update readme with Gradle commands ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11135/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11135/1//COMMIT_MSG@17 PS1, Line 17: - Uses the sources distribution in the wrapper > So now we'll download the wrapper's source artifact in addition to the bina It's all one artifact, but we will download the one that includes sources. This allows you to view the gradle sources and docs directly in the IDE when debugging and developing. As opposed to the decompiled classes. IntelliJ actually prompts you to do this on project import. http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc File java/README.adoc: http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@51 PS1, Line 51: The tests may locate the master and tablet server : binaries by looking in `build/latest/bin` from the root of : the git rep > This isn't true anymore. True, I will just remove this sentence as behavior varies quite a bit depending on the tests. http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@74 PS1, Line 74: for detailed documentation of all pattern options. > Can you provide a single-test example here, since that's likely to be a com I will add a few examples of the most common styles. http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@87 PS1, Line 87: $ ./gradlew :kudu-client:test --tests org.apache.kudu.TestColumnSchema.testEquals > May want to explain (in short) what Gradle caches, so that anyone reading t Cache is probably the wrong word here now that I think about it. "Build state" is more accurate. In general you don't need to use the clean task, but it is a nice escape hatch in case you see weird build behavior or don't trust the incremental compilation. I will add a brief blurb about it. http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@111 PS1, Line 111: ---- > Do we want to make a stronger statement about Maven deprecation? I suppose we should. I will update. http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@113 PS1, Line 113: Note: You generally don't need to run this task, but it can be useful : to rule out any build issues. > Trailing whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/11135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I349ac7259beb1f6b80b80265803a06ec532019d7 Gerrit-Change-Number: 11135 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 07 Aug 2018 03:36:59 +0000 Gerrit-HasComments: Yes
