Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11190 )
Change subject: file_cache: stop using sync_on_close when reopening evicted files ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11190/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11190/2//COMMIT_MSG@11 PS2, Line 11: However, with its removal in commit 9a07b2fed, sync_on_close=true : should no longer be necessary for correctness. > Yea, that makes sense. I forgot that the file cache doesn't allow a way for I don't think we ever relied on sync_on_close, at least not in the block managers. Before the file cache files opened by the block managers were never actually closed (and we'd run out of fds in larger deployments). Can you share more details on what you saw? -- To view, visit http://gerrit.cloudera.org:8080/11190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I845f39ea202ec0cb46ce8e841c6cfb6c3a8dad2c Gerrit-Change-Number: 11190 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 10 Aug 2018 22:31:13 +0000 Gerrit-HasComments: Yes
