Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11190 )
Change subject: file_cache: stop using sync_on_close when reopening evicted files ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11190/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11190/2//COMMIT_MSG@11 PS2, Line 11: However, with its removal in commit 9a07b2fed, sync_on_close=true : should no longer be necessary for correctness. hm, I'm having trouble paging this back in. So, now we no longer ever rely on 'sync_on_close' and for file-cached items we need to make sure that any code that expects them to be synced explicitly calls Sync? Should we note that somewhere in the file_cache.h docs? http://gerrit.cloudera.org:8080/#/c/11190/2//COMMIT_MSG@16 PS2, Line 16: An unnecessary fdatasync system call should no-op, but maybe : that's not the case on older kernels? hm, that's interesting. Do you think maybe the file had been modified by some other program (eg a concurrently running tserver?) -- To view, visit http://gerrit.cloudera.org:8080/11190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I845f39ea202ec0cb46ce8e841c6cfb6c3a8dad2c Gerrit-Change-Number: 11190 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 10 Aug 2018 21:35:31 +0000 Gerrit-HasComments: Yes
