Attila Piros has posted comments on this change. ( http://gerrit.cloudera.org:8080/11199 )
Change subject: Supporting Spark streaming DataFrame in KuduContext. ...................................................................... Patch Set 4: > Could you add tests to demonstrate and prove the functionality this > change is supporting? Also to ensure it doesn't break with future > changes. Unfortunately no idea how. If you check my kudu custom sink repo: > Could you add tests to demonstrate and prove the functionality this > change is supporting? Also to ensure it doesn't break with future > changes. Unfortunately it is not easy: here there is custom sink using the KuduContext in streaming: https://github.com/attilapiros/kudu_custom_sink but in our case we would need the Spark streaming test in memory solution too. -- To view, visit http://gerrit.cloudera.org:8080/11199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iead04539d3514920a5d6803c34715e5686124572 Gerrit-Change-Number: 11199 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Piros <[email protected]> Gerrit-Reviewer: Attila Piros <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 13 Aug 2018 17:01:05 +0000 Gerrit-HasComments: No
