Attila Piros has posted comments on this change. ( http://gerrit.cloudera.org:8080/11199 )
Change subject: Supporting Spark streaming DataFrame in KuduContext. ...................................................................... Patch Set 4: > Patch Set 4: > > > Could you add tests to demonstrate and prove the functionality this > > change is supporting? Also to ensure it doesn't break with future > > changes. > So I have tried: https://gist.github.com/attilapiros/3b5ef42c0f7aa08b0e2c834fbadfc574 But there is an unexpected problem StreamTest is a Scalatest but KuduTestSuite is a JUnitSuite and they cannot be mixed: ``` [ERROR] /home/systest/kudu-public/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/StreamingSuite.scala:27: error: illegal inheritance; superclass QueryTest [ERROR] is not a subclass of the superclass JUnitSuite [ERROR] of the mixin trait KuduTestSuite [ERROR] class StreamingSuite extends StreamTest with KuduTestSuite { [ERROR] ^ ``` Moreover runtime both would create a spark session :( As StreamTest is quite complex the easier solution would be to remove the "with KuduTestSuite" and create the Kudu cluster and simple test table here. Or using composition instead of inheritance via a new class extending KudutestSuite and call before and after methods accordingly. In both cases here would be a scalatest. Is there any reason why JUnitSuite is used here? What is your suggestion? -- To view, visit http://gerrit.cloudera.org:8080/11199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iead04539d3514920a5d6803c34715e5686124572 Gerrit-Change-Number: 11199 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Piros <[email protected]> Gerrit-Reviewer: Attila Piros <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 14 Aug 2018 15:22:20 +0000 Gerrit-HasComments: No
