Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11197 )
Change subject: Add delete_external_catalogs flag to table delete tool ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11197/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11197/1//COMMIT_MSG@9 PS1, Line 9: it might be necessary to : introduce a flag to control the table deletion in the Kudu catalog : independently of the HMS. Not really understanding this: this commit introduces this flag, so how could it "might be necessary" to introduce it in the future? http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/client/client.h@539 PS1, Line 539: /// Delete/drop a table with option. Can you move this so it's next to DeleteTable? http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/11197/1/src/kudu/tools/tool_action_table.cc@39 PS1, Line 39: DEFINE_bool(alter_external_catalogs, true, : "Whether to alter external catalogs, such as the Hive Metastore, " : "when renaming a table."); : DEFINE_bool(delete_external_catalogs, true, : "Whether to delete external catalogs, such as the Hive Metastore, " : "when deleting a table."); These only exist to facilitate "upgrade" workflows that take you from no HMS integration to HMS integration, right? If so, perhaps we should warn users against changing the values of these parameters? -- To view, visit http://gerrit.cloudera.org:8080/11197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a128fb53c974a5c839786204d56408681b434e8 Gerrit-Change-Number: 11197 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 13 Aug 2018 22:33:46 +0000 Gerrit-HasComments: Yes
