Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11197 )
Change subject: Add delete_external_catalogs flag to table delete tool ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/11197/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11197/4//COMMIT_MSG@9 PS4, Line 9: The 'hms fix' tool helps recover from metadata inconsistencies between > Maybe rewrite this description as: Done http://gerrit.cloudera.org:8080/#/c/11197/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11197/4/src/kudu/client/client.h@354 PS4, Line 354: Status KUDU_NO_EXPORT DeleteTableInCatalogs(const std::string& table_name, > According to the google style guide, we should only use function overloads Done http://gerrit.cloudera.org:8080/#/c/11197/4/src/kudu/client/client.h@1233 PS4, Line 1233: // Whether to apply the alteration to external catalogs, such as the Hive > I mentioned this to Dan in an earlier review, but I'd like to see this func Thanks a lot for bringing this up and I will take a note. -- To view, visit http://gerrit.cloudera.org:8080/11197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a128fb53c974a5c839786204d56408681b434e8 Gerrit-Change-Number: 11197 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 06 Sep 2018 22:18:02 +0000 Gerrit-HasComments: Yes
