Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11198 )
Change subject: [hms] disable direct SQL in MiniHms ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11198/1/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/11198/1/src/kudu/hms/mini_hms.cc@256 PS1, Line 256: <name>hive.metastore.try.direct.sql</name> I think the idea here is that direct SQL never works with derby, right? If so, it would be good to add a note to the comment above to that effect, ideally with a link to supporting Hive documentation if that exists. -- To view, visit http://gerrit.cloudera.org:8080/11198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If48fb2551fae739e2f1548bb5ca2187364064703 Gerrit-Change-Number: 11198 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 14 Aug 2018 20:55:13 +0000 Gerrit-HasComments: Yes
