Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11209/5/_includes/bottom_common.html File _includes/bottom_common.html: http://gerrit.cloudera.org:8080/#/c/11209/5/_includes/bottom_common.html@6 PS5, Line 6: Apache Kudu, Kudu, Apache, the Apache feather logo, and the Apache Kudu > nit: please wrap if possible Done http://gerrit.cloudera.org:8080/#/c/11209/4/community.md File community.md: http://gerrit.cloudera.org:8080/#/c/11209/4/community.md@53 PS4, Line 53: * [**Apache Kudu Committers list**](/committers.html) > We were using that before so that these links work even on non-top-level gi I think you mean http://apache.github.io/kudu/ Looking at the current community.html, it seems Jekyll is smart enough to handle this properly: $ curl http://apache.github.io/kudu/community.html 2>/dev/null | grep "coding guidelines" the project <a href="/kudu/docs/contributing.html#_code_style">coding guidelines</a> are before In L95 you can see the source for this link looks like this: [coding guidelines](docs/contributing.html#_code_style) -- To view, visit http://gerrit.cloudera.org:8080/11209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f Gerrit-Change-Number: 11209 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 16 Aug 2018 08:10:40 +0000 Gerrit-HasComments: Yes
