Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11209/5/_includes/bottom_common.html File _includes/bottom_common.html: http://gerrit.cloudera.org:8080/#/c/11209/5/_includes/bottom_common.html@6 PS5, Line 6: Apache Kudu, Kudu, Apache, the Apache feather logo, and the Apache Kudu project logo are either registered trademarks or trademarks of The Apache Software Foundation in the United States and other countries. nit: please wrap if possible http://gerrit.cloudera.org:8080/#/c/11209/4/community.md File community.md: http://gerrit.cloudera.org:8080/#/c/11209/4/community.md@53 PS4, Line 53: * [**Apache Kudu Committers list**](/committers.html) > I replaced it with a relative URL, don't think the site.github.url is neces We were using that before so that these links work even on non-top-level github pages domains, eg if you want to look at your own local fork of the github pages there is some special URL you can get to show it (I can't seem to find that URL right now) but it doesn't end up rooted at any particular domain -- To view, visit http://gerrit.cloudera.org:8080/11209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f Gerrit-Change-Number: 11209 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 15 Aug 2018 23:56:50 +0000 Gerrit-HasComments: Yes
