Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11249 )
Change subject: WIP KUDU-2469 pt 2: fail replicas on CFile corruption ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11249/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11249/2//COMMIT_MSG@18 PS2, Line 18: : I opted to add a new CFILE ErrorHandlerType enum rather than using the : TABLET enum (which is currently a no-op and serves to serialize certain : failures, see error_manager.h for more), as using the TABLET enum would : change the existing error handling behavior of certain errors. I read through the comment in error_manager.h but still don't understand why we can't reuse TABLET for these errors. I don't remember the details of our initial discussion on error serialization, unfortunately. http://gerrit.cloudera.org:8080/#/c/11249/2/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: http://gerrit.cloudera.org:8080/#/c/11249/2/src/kudu/cfile/cfile_reader.cc@348 PS2, Line 348: if (ctx && !ctx->tablet_id().empty()) { Can we assert that this exists? http://gerrit.cloudera.org:8080/#/c/11249/2/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: http://gerrit.cloudera.org:8080/#/c/11249/2/src/kudu/fs/error_manager.h@103 PS2, Line 103: saftey safety -- To view, visit http://gerrit.cloudera.org:8080/11249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63d541443bc68c83fd0ca6d51315143fee04d50f Gerrit-Change-Number: 11249 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 16 Aug 2018 18:40:02 +0000 Gerrit-HasComments: Yes
