Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11249 )
Change subject: KUDU-2469 pt 2: fail replicas on CFile corruption ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/11249/6/src/kudu/cfile/index_btree.h File src/kudu/cfile/index_btree.h: http://gerrit.cloudera.org:8080/#/c/11249/6/src/kudu/cfile/index_btree.h@110 PS6, Line 110: Status LoadBlock(const BlockPointer &block, int depth); > warning: function 'kudu::cfile::IndexTreeIterator::LoadBlock' has a definit Done http://gerrit.cloudera.org:8080/#/c/11249/6/src/kudu/cfile/index_btree.cc File src/kudu/cfile/index_btree.cc: http://gerrit.cloudera.org:8080/#/c/11249/6/src/kudu/cfile/index_btree.cc@318 PS6, Line 318: } > warning: do not use 'else' after 'return' [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/11249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63d541443bc68c83fd0ca6d51315143fee04d50f Gerrit-Change-Number: 11249 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 30 Aug 2018 04:09:03 +0000 Gerrit-HasComments: Yes
