Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11271 )
Change subject: KUDU-2059 fix race in ThreadPool while updating metrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11271/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/11271/1/src/kudu/util/threadpool.cc@553 PS1, Line 553: guard.Unlock(); > How is this a race? I believe metrics_ is immutable once set, as are its me The problem is not with re-entrancy of Increment(), but access to token->metrics_ when ThreadPoolToken is being destructed. I thinks those tokens are destroyed by ThreadPool::Shutdown() You can find the recent stack at: https://issues.apache.org/jira/browse/KUDU-2059?focusedCommentId=16586333&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16586333 -- To view, visit http://gerrit.cloudera.org:8080/11271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I930c7e388001446e67b244a2b3e71d5afdcaf516 Gerrit-Change-Number: 11271 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 19:08:24 +0000 Gerrit-HasComments: Yes
