Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11271 )
Change subject: KUDU-2059 fix race in ThreadPool while updating metrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11271/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/11271/1/src/kudu/util/threadpool.cc@553 PS1, Line 553: guard.Unlock(); > The problem is not with re-entrancy of Increment(), but access to token->me Shutdown() does not destroy tokens; it destroys each token's queued (but not yet run) tasks. Only the token creator may destroy a token; that's why Threadpool::NewToken() returns a token wrapped in a unique_ptr. -- To view, visit http://gerrit.cloudera.org:8080/11271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I930c7e388001446e67b244a2b3e71d5afdcaf516 Gerrit-Change-Number: 11271 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 19:25:01 +0000 Gerrit-HasComments: Yes
