Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, strip apache prefix from package
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py
File build-support/run_dist_test.py:

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py@141
PS2, Line 141: -bin
> Can we drop that suffix for even more consistency?
Hao, would that cause issues with the other packaging issues you are dealing 
with?


http://gerrit.cloudera.org:8080/#/c/11277/2/thirdparty/vars.sh
File thirdparty/vars.sh:

http://gerrit.cloudera.org:8080/#/c/11277/2/thirdparty/vars.sh@211
PS2, Line 211: # TODO(dan): bump to a release version once HIVE-17747 and 
HIVE-16886/HIVE-18526
             : # are published. The SHA below is the current head of branch-2.
> I take it this is still at large?
Yes, the comment is still correct.



--
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 22:20:58 +0000
Gerrit-HasComments: Yes

Reply via email to