Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )
Change subject: Bump Hive version, normalize hive package name ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11277/3/thirdparty/package-hive.sh File thirdparty/package-hive.sh: http://gerrit.cloudera.org:8080/#/c/11277/3/thirdparty/package-hive.sh@37 PS3, Line 37: wget https://archive.apache.org/dist/hive/hive-$VERSION/$ARTIFACT.tar.gz I left this feedback in Hao's patch too, so it may not apply here, but could we use curl here instead, to be more consistent with the rest of the thirdparty scripts? -- To view, visit http://gerrit.cloudera.org:8080/11277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb Gerrit-Change-Number: 11277 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 21 Aug 2018 04:16:28 +0000 Gerrit-HasComments: Yes
