Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )
Change subject: [hms] update the HIVE/HADOOP package scripts ...................................................................... Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG@10 PS1, Line 10: repackagi > repackaging Done http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG@10 PS1, Line 10: choos > choose Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh File thirdparty/package-hadoop.sh: PS1: > Pretty much all of the feedback here applies to package-hive.sh too. Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@26 PS1, Line 26: optional > Nit: optional (lower case). Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@39 PS1, Line 39: Download > Download Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@40 PS1, Line 40: --repackag > --repackage Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@49 PS1, Line 49: if [ ${OPTS_RESULT} != 0 ] ; then > Nit: break this up onto separate lines. Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@51 PS1, Line 51: TS > Nit: separate with a space from the semicolon Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@53 PS1, Line 53: > This was just for debugging, right? Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@55 PS1, Line 55: case "$1" in > Nit: -h | --help) Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@69 PS1, Line 69: fi > Remove this? Done http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@74 PS1, Line 74: fi > Can you construct this list more clearly? Like: Done -- To view, visit http://gerrit.cloudera.org:8080/11274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2 Gerrit-Change-Number: 11274 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 21 Aug 2018 00:17:15 +0000 Gerrit-HasComments: Yes
