Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )
Change subject: [hms] update the HIVE/HADOOP package scripts ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/11274/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11274/2//COMMIT_MSG@10 PS2, Line 10: do Nit: to do http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh File thirdparty/package-hadoop.sh: http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh@49 PS2, Line 49: ; Nit: eliminate extra space here. http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh@72 PS2, Line 72: wget https://archive.apache.org/dist/hadoop/common/$ARTIFACT/$ARTIFACT.tar.gz Should have noticed this earlier, but let's use curl here instead of wget; the rest of the thirdparty scripts use curl. http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh File thirdparty/package-hive.sh: http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh@51 PS2, Line 51: ; Nit: extra space. http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh@75 PS2, Line 75: wget https://archive.apache.org/dist/hive/hive-$VERSION/$ARTIFACT.tar.gz Use curl. -- To view, visit http://gerrit.cloudera.org:8080/11274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2 Gerrit-Change-Number: 11274 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 21 Aug 2018 04:06:36 +0000 Gerrit-HasComments: Yes
