Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11288 )
Change subject: [webui] Convert /tablet and its offshoots to mustache ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Looks good, just a few nits. http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@148 PS2, Line 148: Tablet nit: replace 'Tablet' --> 'request'? http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@398 PS2, Line 398: EasyJson* output = resp->output; nit: here and elsewhere move this closer to the first usage of output (in this case that's line 410 below). http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@442 PS2, Line 442: if (!LoadTablet(tserver_, req, &tablet_id, &replica, resp)) return Just for my edification: how does mustache renders the page in the case if the expected 'tablet_id' and 'log_anchors' are missing? -- To view, visit http://gerrit.cloudera.org:8080/11288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2 Gerrit-Change-Number: 11288 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 22 Aug 2018 19:20:40 +0000 Gerrit-HasComments: Yes
