Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11288 )
Change subject: [webui] Convert /tablet and its offshoots to mustache ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@148 PS2, Line 148: Tablet > nit: replace 'Tablet' --> 'request'? Done http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@398 PS2, Line 398: EasyJson* output = resp->output; > nit: here and elsewhere move this closer to the first usage of output (in t Done http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@442 PS2, Line 442: if (!LoadTablet(tserver_, req, &tablet_id, &replica, resp)) return > Just for my edification: how does mustache renders the page in the case if If the tablet isn't found or the id is invalid it prints a message saying so. A tablet must have a log so I think there's always a registry. If there's no log anchors currently then there's a header and nothing underneath. -- To view, visit http://gerrit.cloudera.org:8080/11288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2 Gerrit-Change-Number: 11288 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 22 Aug 2018 20:50:39 +0000 Gerrit-HasComments: Yes
