Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )
Change subject: Add protobuf generated files to Eclipse project classpath. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11310/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11310/2//COMMIT_MSG@9 PS2, Line 9: With this change Eclipse can compile all Java projects : and allows to can run JUnit tests from Eclipse. Maybe reword as: "With this change Eclipse can compile all Kudu Java projects and can run JUnit tests directly"? http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle@38 PS2, Line 38: classpath { Nit: wrong indentation here? http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle@41 PS2, Line 41: entries += new SourceFolder("${protobuf.generatedFilesBaseDir}/main/java".replace("${project.projectDir}",""), null) Split this line up and maybe add a comment explaining what 'null' is, and what replace() accomplishes? Also separate the two operands in replace() with a space after the comma. -- To view, visit http://gerrit.cloudera.org:8080/11310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586 Gerrit-Change-Number: 11310 Gerrit-PatchSet: 2 Gerrit-Owner: Greg Solovyev <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 23 Aug 2018 22:47:29 +0000 Gerrit-HasComments: Yes
