Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )
Change subject: Add protobuf generated files to Eclipse project classpath. ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11310/5/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/11310/5/java/gradle/protobuf.gradle@47 PS5, Line 47: entries += new SourceFolder("${protobuf.generatedFilesBaseDir}/main/java" Nit: You could use something like below. If you prefer the existing way, I am okay to submit as is. def relPath = projectDir.toPath().relativize(file("${protobuf.generatedFilesBaseDir}/main/java").toPath()) entries += new SourceFolder(relPath.toString(), null) -- To view, visit http://gerrit.cloudera.org:8080/11310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586 Gerrit-Change-Number: 11310 Gerrit-PatchSet: 5 Gerrit-Owner: Greg Solovyev <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 25 Aug 2018 02:59:04 +0000 Gerrit-HasComments: Yes
