Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11302 )
Change subject: util: add once class based on std::call_once ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11302/1/src/kudu/util/once.h File src/kudu/util/once.h: http://gerrit.cloudera.org:8080/#/c/11302/1/src/kudu/util/once.h@132 PS1, Line 132: size_t memory_footprint_excluding_this() const; Why doesn't this variant need to offer memory_footprint_including_this()? -- To view, visit http://gerrit.cloudera.org:8080/11302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide56057a800bf07923031df5a2a76a42f0b15358 Gerrit-Change-Number: 11302 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 24 Aug 2018 18:55:07 +0000 Gerrit-HasComments: Yes
