Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11302 )
Change subject: util: add once class based on std::call_once ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11302/2/src/kudu/util/once.h File src/kudu/util/once.h: http://gerrit.cloudera.org:8080/#/c/11302/2/src/kudu/util/once.h@116 PS2, Line 116: class KuduOnceLambda { Nit. I know this is super similar to KuduOnceDynamic above, but having the comments on the methods here too would be nice. -- To view, visit http://gerrit.cloudera.org:8080/11302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide56057a800bf07923031df5a2a76a42f0b15358 Gerrit-Change-Number: 11302 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 27 Aug 2018 15:46:09 +0000 Gerrit-HasComments: Yes
