[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/11077 )
Change subject: [KUDU-2521] Java Implementation for BloomFilter ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11077/1/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java File java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java: http://gerrit.cloudera.org:8080/#/c/11077/1/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java@139 PS1, Line 139: obe.mixH > > I think it's necessary to make the hashing consistent with the blooms on I think my previous understanding is not correct. Yes, Dan~ there is no necessity to make the PK bloom filters use the same hash function as this predicate bloom filter. I re-write the BloomFIlter at: https://gerrit.cloudera.org/#/c/11333/1/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java In current change: 1. User has flexibility to define hash function and Murmur2 by default; 2. I removed some unrelated public API and did some renaming (some of the interface used for test is still kept); Note that Spark internal is using Murmur3 by default, which is different with Kudu internal. I removed the test at https://gerrit.cloudera.org/#/c/11333/1/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java, please take a look at the structure and whether the interface is appropriate. I will re-write the test later. -- To view, visit http://gerrit.cloudera.org:8080/11077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c5dce4d24707c068c5ab94e5d311b12b3251b8 Gerrit-Change-Number: 11077 Gerrit-PatchSet: 4 Gerrit-Owner: [email protected] Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Sun, 26 Aug 2018 15:52:45 +0000 Gerrit-HasComments: Yes
