[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 )
Change subject: [KUDU-2521] Java Implementation for BloomFilter ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11333/2/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java File java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java: http://gerrit.cloudera.org:8080/#/c/11333/2/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java@17 PS2, Line 17: Thanks advice on How-To-Use-Gerrit. I'm finding Gerrit is easier to use now :) http://gerrit.cloudera.org:8080/#/c/11333/2/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java@33 PS2, Line 33: private byte[] bitmap; should we provided a clear method like below: public void clear() { for (int i = 0; i < bitmap.length(); i++) { bitmap[i] =0 } } http://gerrit.cloudera.org:8080/#/c/11333/2/java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java@134 PS2, Line 134: // We can consider to provide some other options like Murmur3, CityHash in the future. Hmm, only Murmur2 is provided. Note that Spark is using Murmur3. -- To view, visit http://gerrit.cloudera.org:8080/11333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32673c008f9958088d281c2c198c543bfea2eb8e Gerrit-Change-Number: 11333 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Fri, 31 Aug 2018 09:02:43 +0000 Gerrit-HasComments: Yes
