Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11365 )

Change subject: Improve runtime of slow java client security test.
......................................................................


Patch Set 1:

> Patch Set 1:
>
> (1 comment)
>
> This change would be great to have as the test runs about 2x as long as any 
> other test.
> 
> It looks like the change is fairly flaky with this change. It fails on 
> dist-test about 40% of the time with the error below:

Yea, maybe moving this to be an integration test would be better rather than 
potentially introducing flakiness? Agreed that long running tests suck, but 
unfortunately it's not so easy to mock out the advancement of time across 
clients, servers, and krb5 libraries without some pretty substantial effort.


--
To view, visit http://gerrit.cloudera.org:8080/11365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Fri, 31 Aug 2018 03:36:37 +0000
Gerrit-HasComments: No

Reply via email to