Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 )
Change subject: [tablet] Add tablet metric for number of diskrowsets ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc@2257 PS3, Line 2257: // Take a ref to components to avoid a TOCTOU error. Is that necessary with component_lock_ held just above? http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc@2259 PS3, Line 2259: return components ? components->rowsets->all_rowsets().size() : 0; So the old implementation could dereference null here? -- To view, visit http://gerrit.cloudera.org:8080/11378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e Gerrit-Change-Number: 11378 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 04 Sep 2018 17:47:08 +0000 Gerrit-HasComments: Yes
