Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 )
Change subject: [tablet] Add tablet metric for number of diskrowsets ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11378/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11378/1/src/kudu/tablet/tablet.cc@173 PS1, Line 173: mber of > this is specifically rowsets on disk, right? does it include MRS? Right, just diskrowsets. I'll update the name and description. http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc@2257 PS3, Line 2257: } > Is that necessary with component_lock_ held just above? Done http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc@2259 PS3, Line 2259: void Tablet::PrintRSLayout(ostream* o) { > So the old implementation could dereference null here? Yes. If metrics are gathered before the tablet is opened, as tested by TestMetricsInit in tablet-test. -- To view, visit http://gerrit.cloudera.org:8080/11378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e Gerrit-Change-Number: 11378 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 04 Sep 2018 18:00:21 +0000 Gerrit-HasComments: Yes
