Andrew Wong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11389


Change subject: cfile-test: pass in IOContext on Open()
......................................................................

cfile-test: pass in IOContext on Open()

Previously, on certain machines, cfile-test's TestDataCorruption would
fail 100% of the time when attempting to read from a null IOContext. The
passed-in ReaderOptions struct was constructed with the default
constructor, and because no default was set for its io_context member,
this resulted in undefined behavior, which explains why this wasn't
caught in pre-commit.

This patch updates cfile-test to correctly pass in an IOContext, and
assigns a default for ReaderOption's io_context.

Change-Id: Iaed883d26075ed1823882a7f7b18834f39b0732d
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_util.h
2 files changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/11389/1
--
To view, visit http://gerrit.cloudera.org:8080/11389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaed883d26075ed1823882a7f7b18834f39b0732d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>

Reply via email to