Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11389 )
Change subject: cfile-test: pass in IOContext on Open() ...................................................................... cfile-test: pass in IOContext on Open() Previously, on certain machines, cfile-test's TestDataCorruption would fail 100% of the time when attempting to read from a null IOContext. The passed-in ReaderOptions struct was constructed with the default constructor, and because no default was set for its io_context member, this resulted in undefined behavior, which explains why this wasn't caught in pre-commit. This patch updates cfile-test to correctly pass in an IOContext, and assigns a default for ReaderOption's io_context. Change-Id: Iaed883d26075ed1823882a7f7b18834f39b0732d Reviewed-on: http://gerrit.cloudera.org:8080/11389 Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_util.h 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iaed883d26075ed1823882a7f7b18834f39b0732d Gerrit-Change-Number: 11389 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins
