Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11377 )
Change subject: mini cluster: Add scripts to build binaries for testing use ...................................................................... Patch Set 1: (6 comments) > Did you try to verify that binaries built on older OS X run on a newer one? No, I only have tried to build this way on High Sierra with Homebrew. On the bright side, Mac users tend to upgrade the OS pretty regularly. http://gerrit.cloudera.org:8080/#/c/11377/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11377/1//COMMIT_MSG@12 PS1, Line 12: preferably an old OS, such as RHEL 6 > Answering my own question: the build system's openssl is coming along for t Statically linking results in a larger artifact because we have to ship both kudu-master and kudu-tserver http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/build_mini_cluster_binaries.sh File build-support/build_mini_cluster_binaries.sh: http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/build_mini_cluster_binaries.sh@53 PS1, Line 53: /usr/local/opt/openssl > That makes sense only in case of Homebrew, but it will not work in case of Thanks for the pointer, I'll take a look at that implementation. http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/relocate_binaries_for_mini_cluster.py File build-support/relocate_binaries_for_mini_cluster.py: http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/relocate_binaries_for_mini_cluster.py@35 PS1, Line 35: import subprocess > You might find the 'sh' module to be an easier way of calling small Unix co Thanks for the suggestion, I haven't used that lib before. I'll look into it. http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/relocate_binaries_for_mini_cluster.py@171 PS1, Line 171: def get_dep_library_paths_linux(binary_path): > Can you refactor and reuse ldd_deps() from dist_test.py here? I'll take a look at that. http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/relocate_binaries_for_mini_cluster.py@251 PS1, Line 251: See relocate_deps(). Linux implementation. > This refers to something that doesn't exist? Ah, should be relocate_target() http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/relocate_binaries_for_mini_cluster.py@284 PS1, Line 284: Kerberos|libSystem|libncurses > What about libc++ and others? It's not excluded? I thought we might want to include libc++ in case we use our own LLVM version. -- To view, visit http://gerrit.cloudera.org:8080/11377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f90cfe80f6830177bf6ea9e0711eb0d034f75 Gerrit-Change-Number: 11377 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 06 Sep 2018 04:33:07 +0000 Gerrit-HasComments: Yes
