Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 )
Change subject: HMS integration: set table owner field in HMS table metadata ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG@17 PS1, Line 17: This replacement table metadata will omit the table : owner Did you consider passing in the table owner name as a flag to the tool? Is that possible given the admin's privileges? http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG@20 PS1, Line 20: hte nit: the http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG@22 PS1, Line 22: As such I think it's safer to omit : table ownership information in this case. An admin can re-assign the : table ownership through Beeline or Impala given sufficient credentials. What does the resulting ownerless table metadata mean in terms of privileges? What are the sufficient credentials to modifying an ownerless table? Is the behavior of these tables dependent on the privilege-enforcing entity (e.g. Sentry)? http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/integration-tests/master_hms-itest.cc@643 PS1, Line 643: table.owner, "test-user" nit: expected value should go first -- To view, visit http://gerrit.cloudera.org:8080/11398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a25aa0bb52bdd28df28a078fe91f55db9e29482 Gerrit-Change-Number: 11398 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 06 Sep 2018 23:58:39 +0000 Gerrit-HasComments: Yes
