Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 )
Change subject: HMS integration: set table owner field in HMS table metadata ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG@11 PS1, Line 11: A follow-up patch Do we need to mention 'ALTER TABLE SET OWNER' is not supported for Kudu tables? http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG@16 PS1, Line 16: fix The same for 'upgrade' tool? http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG@22 PS1, Line 22: omit : table ownership information What will happen of ownership is omitted? Will that information be blank in the HMS? I guess this is a similar question to Andrew's. http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/tools/kudu-tool-test.cc@2445 PS1, Line 2445: TestCheckAndAutomaticFixHmsMetadata Does this include any test cases that the owner is omitted? http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/tools/tool_action_hms.cc@168 PS1, Line 168: boost::none Does this mean if the HMS table have ownership information but Kudu table doesn't, the check will fail? -- To view, visit http://gerrit.cloudera.org:8080/11398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a25aa0bb52bdd28df28a078fe91f55db9e29482 Gerrit-Change-Number: 11398 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 07 Sep 2018 01:43:22 +0000 Gerrit-HasComments: Yes
