Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11197 )
Change subject: Add modify_external_catalogs flag to table delete tool ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/11197/6/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11197/6/src/kudu/client/client.h@54 PS6, Line 54: class MasterHmsTest_TestAlterTable_Test; : class MasterHmsUpgradeTest_TestRenameExistingTables_Test; And remove these? http://gerrit.cloudera.org:8080/#/c/11197/6/src/kudu/client/client.h@65 PS6, Line 65: namespace tools { : class LeaderMasterProxy; : std::string GetMasterAddresses(const client::KuduClient&); : void SetModifyExternalCatalogs(client::KuduTableAlterer*, bool); : } // namespace tools Do we still need this friendship? http://gerrit.cloudera.org:8080/#/c/11197/6/src/kudu/client/client.h@1230 PS6, Line 1230: : friend void tools::SetModifyExternalCatalogs(KuduTableAlterer*, bool); : FRIEND_TEST(kudu::MasterHmsTest, TestAlterTable); : FRIEND_TEST(kudu::MasterHmsUpgradeTest, TestRenameExistingTables); Should be able to remove these now that modify_external_catalogs() is public? -- To view, visit http://gerrit.cloudera.org:8080/11197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a128fb53c974a5c839786204d56408681b434e8 Gerrit-Change-Number: 11197 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 07 Sep 2018 04:29:34 +0000 Gerrit-HasComments: Yes
