Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 )
Change subject: KUDU-2245 Graceful leadership transfer ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/11251/8/src/kudu/consensus/consensus-test-util.h File src/kudu/consensus/consensus-test-util.h: http://gerrit.cloudera.org:8080/#/c/11251/8/src/kudu/consensus/consensus-test-util.h@355 PS8, Line 355: virtual void StartElection(const RunLeaderElectionRequestPB* /*request*/, > warning: parameter 'requestoverride' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/11251/8/src/kudu/consensus/consensus-test-util.h@356 PS8, Line 356: RunLeaderElectionResponsePB* /*response*/, > warning: parameter 'response' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/11251/8/src/kudu/consensus/consensus-test-util.h@357 PS8, Line 357: rpc::RpcController* /*controller*/, > warning: parameter 'controller' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/11251/8/src/kudu/consensus/consensus-test-util.h@358 PS8, Line 358: const rpc::ResponseCallback& /*callback*/) override {} > warning: parameter 'callback' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/11251/10/src/kudu/tools/tool_replica_util.cc File src/kudu/tools/tool_replica_util.cc: http://gerrit.cloudera.org:8080/#/c/11251/10/src/kudu/tools/tool_replica_util.cc@310 PS10, Line 310: proxy 'proxy' was constructed at L149, with old leader info. If leadership had actually changed, and the client had had time to realize it, then this RPC would be sent to the wrong server, leading to the test failure seen in the precommit. Likely, the client always returned stale info when stepdown was abrupt, because there would have been no new leader for the failure period + the time of an election, but with graceful stepdown the period was reduced to just the time of an election. -- To view, visit http://gerrit.cloudera.org:8080/11251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic97343af9eb349556424c999799ed5e2941f0083 Gerrit-Change-Number: 11251 Gerrit-PatchSet: 10 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 21 Sep 2018 20:22:12 +0000 Gerrit-HasComments: Yes
