Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 )
Change subject: KUDU-2245 Graceful leadership transfer ...................................................................... Patch Set 11: > (9 comments) > > I tried doing a bit of a refactor on the CheckMoveComplete code but > maybe I do not understand it as well as I thought. Maybe we should > chat about it tomorrow? After looking at the step-by-step explanation I think it makes sense, yep. As we discussed offline, it makes sense to separate that refactoring into its own patch. That will be easier to track and review, especially given the fact that it's a bug. -- To view, visit http://gerrit.cloudera.org:8080/11251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic97343af9eb349556424c999799ed5e2941f0083 Gerrit-Change-Number: 11251 Gerrit-PatchSet: 11 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 24 Sep 2018 17:58:10 +0000 Gerrit-HasComments: No
