Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )
Change subject: Fix Pandas Tests in Python 2.6 client ...................................................................... Patch Set 3: > Patch Set 3: > > You could flip the argument here and ask why would it be too difficult for > developers looking to test pandas integration to install pandas? I suppose > we could get away with leaving it in requirements.txt and removing it from > setup.py, however, if forced to pick between the two options, I'd say this > introduces unnecessary confusion. To be clear, I don't have a strong opinion on the matter, and I'm not opposed to this change. I was just trying to understand the motivation; I figured maybe I overlooked something in how kudu-client was built, tested, or deployed. However, I do think if we're going to leave pandas in requirements.txt, we should also leave it in setup.py. That's because I think it's valuable for "pip install -r requirements.txt" to install both build and test dependencies; "python setup.py test" can certainly download dependencies listed in tests_require, but it's harder to control that process (e.g. it's harder to choose an alternate mirror). -- To view, visit http://gerrit.cloudera.org:8080/11557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8 Gerrit-Change-Number: 11557 Gerrit-PatchSet: 3 Gerrit-Owner: [email protected] Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 01 Oct 2018 23:30:28 +0000 Gerrit-HasComments: No
