[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )
Change subject: Remove Pandas as a Python Client Requirement ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG@12 PS3, Line 12: work done here https://gerrit.cloudera.org/#/c/10809/4 > dependency Done http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@506 PS3, Line 506: # We need to install Pandas manually since its not a required package but is needed > Nit: it's Done http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@508 PS3, Line 508: # pandas 0.18 dropped support for python 2.6. > Can you pin this to 0.18, which was the last version to support Python 2.6? Done http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@567 PS3, Line 567: # > Nit: leading whitespace here. Done http://gerrit.cloudera.org:8080/#/c/11557/3/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/11557/3/python/kudu/tests/test_scanner.py@385 PS3, Line 385: @pytest.mark.skipif((not(kudu.CLIENT_SUPPORTS_PANDAS) and : (not(kudu.CLIENT_SUPPORTS_DECIMAL))), > Can this be formatted like this? Done http://gerrit.cloudera.org:8080/#/c/11557/3/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11557/3/python/setup.py@197 PS3, Line 197: # pytest 3.3 [1] and pytest-timeout 1.2.1 [2] dropped : # support for python 2.6. : # : # 1. https://docs.pytest.org/en/latest/changelog.html#id164 : # 2. https://pypi.org/project/pytest-timeout/#id5 : tests_require=['pytest >=2.8,<3.3', > Update this to remove the pandas reference. Done -- To view, visit http://gerrit.cloudera.org:8080/11557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8 Gerrit-Change-Number: 11557 Gerrit-PatchSet: 4 Gerrit-Owner: [email protected] Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Thu, 04 Oct 2018 15:17:22 +0000 Gerrit-HasComments: Yes
