Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11609 )
Change subject: KUDU-2324 Add gflags to disable individual maintenance ops ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11609/4/src/kudu/tablet/tablet_replica_mm_ops.cc File src/kudu/tablet/tablet_replica_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/11609/4/src/kudu/tablet/tablet_replica_mm_ops.cc@43 PS4, Line 43: TAG_FLAG(enable_flush_memrowset, runtime); > Do you think it's worth adding the 'unsafe' flag as well? My thoughts as well. Taking out MRS and DMS flushes seems somewhat dangerous (e.g. really easy to hit memory limits, which you note, but might be worth safeguarding this to make users aware of how severe it will probably be) -- To view, visit http://gerrit.cloudera.org:8080/11609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4823c067883897718cc225ef85a0aaf67f1df38 Gerrit-Change-Number: 11609 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Oct 2018 23:18:57 +0000 Gerrit-HasComments: Yes
