Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11609 )
Change subject: KUDU-2324 Add gflags to disable individual maintenance ops ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11609/4/src/kudu/tablet/tablet_replica_mm_ops.cc File src/kudu/tablet/tablet_replica_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/11609/4/src/kudu/tablet/tablet_replica_mm_ops.cc@45 PS4, Line 45: DEFINE_bool(enable_flush_deltamemstores, true, > shouldn't this be flagged unsafe as well? So, I think it's kind of a wash between advanced and unsafe. From flag_tags.h, advanced flags are for advanced users or debugging purposes (like these flags) and aren't likely to be actively harmful (these aren't "actively" harmful if you ask me, unless you aren't advanced enough to know how to use them!). Unsafe flags are for internal use only, like testing, which is kinda true here since I imagine using them either for testing (delay mm ops for a bit to make other easier to see occur, or to see the suspended ones happen all at once, etc) or for temporarily working around serious bugs. I wouldn't call turning them off arbitrarily bad...it doesn't crash the server, it just leads to increasing resource usage in a particular way. I don't think the flags should be marked as both advanced and unsafe, so I'll just switch all of them to unsafe. -- To view, visit http://gerrit.cloudera.org:8080/11609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4823c067883897718cc225ef85a0aaf67f1df38 Gerrit-Change-Number: 11609 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 09 Oct 2018 15:09:01 +0000 Gerrit-HasComments: Yes
