Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11635 )
Change subject: Improve logging for mini HMS and Sentry services ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11635/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11635/1//COMMIT_MSG@10 PS1, Line 10: Both services now log warnings or errors to the console, and : info level messages to a file in the mini cluster root. Do you know if we collect these in build-and-test.sh? If not, should we be? http://gerrit.cloudera.org:8080/#/c/11635/1/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/11635/1/src/kudu/hms/mini_hms.cc@326 PS1, Line 326: 'hive-log4j.properties' hive-log4j2.properties? Also, no such magic for sentry? http://gerrit.cloudera.org:8080/#/c/11635/1/src/kudu/sentry/mini_sentry.cc File src/kudu/sentry/mini_sentry.cc: http://gerrit.cloudera.org:8080/#/c/11635/1/src/kudu/sentry/mini_sentry.cc@257 PS1, Line 257: WARN messages to the stderr Is Sentry less verbose? Is that why we're using WARN here instead of ERROR? Mind clarifying in the commit msg or in this comment? -- To view, visit http://gerrit.cloudera.org:8080/11635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd14cda83d56b0588667b9a3de260ffa62842adc Gerrit-Change-Number: 11635 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 09 Oct 2018 22:59:01 +0000 Gerrit-HasComments: Yes
