Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11635 )

Change subject: Improve logging for mini HMS and Sentry services
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11635/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11635/1//COMMIT_MSG@10
PS1, Line 10: Both services now log warnings or errors to the console, and
            : info level messages to a file in the mini cluster root.
> Yes, I believe this is done in run_dist_test.py when the test fails.
I picked on master-hms-itest in the pre-commit to see; it looks like we don't 
collect the remnants/logs of the mini-clusters; maybe that's fine though. 
Thinking about it more, I don't think we've ever collected minicluster files 
after running a test; even in the case of Java tests, the miniclusters just log 
everything to stdout or stderr rather than logging to files. At the very least, 
I saw the appropriate HMS error messages in the logs that we _do_ collect.



--
To view, visit http://gerrit.cloudera.org:8080/11635
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd14cda83d56b0588667b9a3de260ffa62842adc
Gerrit-Change-Number: 11635
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 10 Oct 2018 00:28:25 +0000
Gerrit-HasComments: Yes

Reply via email to