Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11658 )
Change subject: [sentry] move ParseTableName to table_util ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11658/1/src/kudu/util/table_util-test.cc File src/kudu/util/table_util-test.cc: http://gerrit.cloudera.org:8080/#/c/11658/1/src/kudu/util/table_util-test.cc@50 PS1, Line 50: EXPECT_TRUE(ParseTableName("no-table", &db, &tbl).IsInvalidArgument()); not your fault, but looks like these two test cases got duplicated between lines 50-53 http://gerrit.cloudera.org:8080/#/c/11658/1/src/kudu/util/table_util.cc File src/kudu/util/table_util.cc: http://gerrit.cloudera.org:8080/#/c/11658/1/src/kudu/util/table_util.cc@36 PS1, Line 36: Status ParseTableName(const string& table_name, Given this is no longer 'scoped' under the hms module, I think it makes sense to change the name to 'ParseHiveTableIdent' or similar. -- To view, visit http://gerrit.cloudera.org:8080/11658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fff5aaff623ac65a949f6cabebd9eca997f5cdc Gerrit-Change-Number: 11658 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 17:06:23 +0000 Gerrit-HasComments: Yes
