Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11658 )
Change subject: [sentry] move ParseTableName to table_util ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11658/3/src/kudu/common/table_util.h File src/kudu/common/table_util.h: http://gerrit.cloudera.org:8080/#/c/11658/3/src/kudu/common/table_util.h@34 PS3, Line 34: ParseHiveTableIdent > Short for 'identifier'. I suggested this name because it's parsing both th Ah, gotcha. I thought it was "Identity" or something, which seemed kind of odd, but "Identifier" makes sense. Just adding the word "identifier" somewhere in the comment would help. Or maybe ParseHiveDbAndTable()? GetHiveDbAndTable()? -- To view, visit http://gerrit.cloudera.org:8080/11658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fff5aaff623ac65a949f6cabebd9eca997f5cdc Gerrit-Change-Number: 11658 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 15 Oct 2018 23:29:24 +0000 Gerrit-HasComments: Yes
