Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 )
Change subject: Remove column ids from KuduSchema::ToString ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11668/1/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/11668/1/src/kudu/common/schema.h@735 PS1, Line 735: std::string ToString(ToStringMode mode = ToStringMode::WITH_COLUMN_IDS) const; Did you look at who else calls this? Seems like we might just want to change the behavior for all cases? -- To view, visit http://gerrit.cloudera.org:8080/11668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193 Gerrit-Change-Number: 11668 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 12 Oct 2018 19:26:20 +0000 Gerrit-HasComments: Yes
