Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11668 )
Change subject: Remove column ids from KuduSchema::ToString ...................................................................... Remove column ids from KuduSchema::ToString 708d0f736c5a9d60ca02041bdb3b753e11478b6d added a KuduSchema::ToString method, which calls into Schema::ToString. This is fine except Schema::ToString includes the column ids when they are set, and that information is implementation and ought not be shown to the user. I think the original testing missed this because it never called KuduSchema::ToString on a KuduSchema built from a Schema that had column ids. A new test fixes this oversight. Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193 Reviewed-on: http://gerrit.cloudera.org:8080/11668 Tested-by: Will Berkeley <[email protected]> Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/client/client-unittest.cc M src/kudu/client/schema.cc M src/kudu/common/schema-test.cc M src/kudu/common/schema.cc M src/kudu/common/schema.h 5 files changed, 49 insertions(+), 6 deletions(-) Approvals: Will Berkeley: Verified Dan Burkert: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193 Gerrit-Change-Number: 11668 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]>
