Hello Andrew Wong, Adar Dembo, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11693
to review the following change.
Change subject: Fix thrift operator< implementations
......................................................................
Fix thrift operator< implementations
The previous implementation didn't account for unset optional fields,
and did not short-circuit after finding the first field which was
smaller. Buggy operator< is problematic because the std::map and
std::set types require the operator< to maintain a total ordering; if it
doesn't then the set and map invariants will not hold.
Change-Id: I1aacf602c603b05433c357a4a236ba0b9e521392
---
M src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/thrift_operators-test.cc
M src/kudu/sentry/thrift_operators.cc
3 files changed, 81 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/11693/1
--
To view, visit http://gerrit.cloudera.org:8080/11693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aacf602c603b05433c357a4a236ba0b9e521392
Gerrit-Change-Number: 11693
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
