Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11693 )
Change subject: Fix thrift operator< implementations ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11693/2/src/kudu/sentry/thrift_operators-test.cc File src/kudu/sentry/thrift_operators-test.cc: http://gerrit.cloudera.org:8080/#/c/11693/2/src/kudu/sentry/thrift_operators-test.cc@46 PS2, Line 46: TSentryPrivilege Can you add a test for TSentryAuthorizable and TSentryRole as well? http://gerrit.cloudera.org:8080/#/c/11693/2/src/kudu/sentry/thrift_operators.cc File src/kudu/sentry/thrift_operators.cc: http://gerrit.cloudera.org:8080/#/c/11693/2/src/kudu/sentry/thrift_operators.cc@37 PS2, Line 37: other.__isset.field This will evaluate to false if the field is set for 'this' but unset for 'other'? Is this desired? -- To view, visit http://gerrit.cloudera.org:8080/11693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aacf602c603b05433c357a4a236ba0b9e521392 Gerrit-Change-Number: 11693 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 16 Oct 2018 20:12:44 +0000 Gerrit-HasComments: Yes
