Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 )
Change subject: KUDU-2245 Graceful leadership transfer ...................................................................... Patch Set 15: (4 comments) Looks good just a plumbing nitpick now http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/peer_manager.cc File src/kudu/consensus/peer_manager.cc: http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/peer_manager.cc@110 PS15, Line 110: void PeerManager::StartElection(const std::string& uuid) { Seems like this function should return a Status so we can decide how to handle errors one level up. http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/peer_manager.cc@119 PS15, Line 119: return; how about: return Status::NotFound(Substitute("Unable to start an election on unknown peer $0", uuid)); http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/peer_manager.cc@121 PS15, Line 121: Status s = peer->StartElection(); how about; RETURN_NOT_OK_PREPEND(peer->StartElection(), Substitute("Failed to start election on peer $0", uuid)); return Status::OK(); http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/raft_consensus.cc@991 PS15, Line 991: peer_manager_->StartElection(peer_uuid); can we do the warning here? -- To view, visit http://gerrit.cloudera.org:8080/11251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic97343af9eb349556424c999799ed5e2941f0083 Gerrit-Change-Number: 11251 Gerrit-PatchSet: 15 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 05:11:05 +0000 Gerrit-HasComments: Yes
